Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EXPERIMENT: port to rowan#35 #2182

Closed
wants to merge 2 commits into from
Closed

EXPERIMENT: port to rowan#35 #2182

wants to merge 2 commits into from

Conversation

CAD97
Copy link
Contributor

@CAD97 CAD97 commented Nov 5, 2019

Followup to #2161.

@lnicola, can you test this branch as well?

On my machine, benchmark times seem to be pretty much within noise compared to without this experiment. I still (think I) can't test the allocation pressure on Windows, so I'd appreciate someone else confirming my results and sharing how allocation pressure compares.

@CAD97 CAD97 mentioned this pull request Nov 5, 2019
Closed
@lnicola
Copy link
Member

lnicola commented Nov 5, 2019 •
edited
Loading

I only tested the new branch, the old numbers are from #2161 (comment), running on the same rust-analyzer clone.

Database loaded, 220 roots, 228.586809ms Crates in this dir: 27 Total modules found: 332 Total declarations: 11174 Total functions: 3859 Item Collection: 7.452812617s, 349mb allocated 382mb resident Total expressions: 89607 Expressions of unknown type: 6961 (7%) Expressions of partially unknown type: 3526 (3%) Type mismatches: 3613 Inference: 14.199758921s, 946mb allocated 990mb resident Total: 21.652788856s, 946mb allocated 990mb resident 154mb CrateDefMapQuery 110mb TraitSolveQuery (deps) 72mb ImplDatumQuery (deps) 42mb InferQuery (deps) 40mb MacroArgQuery 32mb ImplDatumQuery 26mb RawItemsQuery 20mb BodyHirQuery 19mb InferQuery 12mb ImplsInModuleQuery 11mb GenericParamsQuery (deps) 9mb ParseQuery 8mb ImplsForTraitQuery (deps) 8mb GenericParamsQuery 7mb BodyWithSourceMapQuery 7mb ImplsForTraitQuery 6mb MacroArgQuery (deps) 6mb MacroExpandQuery (deps) 6mb ParseMacroQuery (deps) 5mb AstIdMapQuery (deps) 5mb RawItemsQuery (deps) 5mb ImplsInModuleWithSourceMapQuery (deps) 5mb RawItemsWithSourceMapQuery (deps) 4mb MacroDefQuery 4mb GenericPredicatesQuery (deps) 4mb AstIdMapQuery 4mb TypeForDefQuery (deps) 4mb CrateDefMapQuery (deps) 2993kb ExprScopesQuery 2800kb BodyWithSourceMapQuery (deps) 2539kb GenericDefaultsQuery (deps) 2531kb FnDataQuery 2448kb ImplsInCrateQuery (deps) 2290kb CallableItemSignatureQuery (deps) 1769kb BodyHirQuery (deps) 1661kb FnDataQuery (deps) 1448kb RawItemsWithSourceMapQuery 1260kb ExprScopesQuery (deps) 1083kb TypeForDefQuery 1014kb GenericPredicatesQuery 944kb ImplsInModuleQuery (deps) 939kb ImplsInModuleWithSourceMapQuery 930kb CallableItemSignatureQuery 843kb TypeForFieldQuery (deps) 637kb ParseQuery (deps) 626kb TypeAliasDataQuery (deps) 575kb StructDatumQuery (deps) 498kb TypeAliasDataQuery 443kb ImplsInCrateQuery 435kb StructDatumQuery 320kb ModuleLangItemsQuery (deps) 294kb EnumDataQuery 274kb GenericDefaultsQuery 266kb TraitSolveQuery 256kb TraitDatumQuery 250kb StructDataQuery 197kb TraitDatumQuery (deps) 193kb MacroDefQuery (deps) 168kb StructDataQuery (deps) 142kb MacroExpandQuery 122kb TraitItemsIndexQuery (deps) 92kb TypeForFieldQuery 87kb ParseMacroQuery 82kb EnumDataQuery (deps) 79kb TraitDataQuery (deps) 68kb LangItemQuery (deps) 23kb ConstDataQuery (deps) 23kb TraitDataQuery 14kb ConstDataQuery 8kb CrateLangItemsQuery (deps) 8kb AssociatedTyDataQuery (deps) 4096b TraitItemsIndexQuery 4096b StaticDataQuery (deps) 4096b ModuleLangItemsQuery 4096b CrateLangItemsQuery 0b SourceRootCratesQuery 0b SourceRootCratesQuery (deps) 0b StaticDataQuery 0b LangItemQuery 0b DocumentationQuery 0b DocumentationQuery (deps) 0b AssociatedTyDataQuery leftover: 265mb 
custom-green
Total: 21.652788856s, 946mb allocated 990mb resident
Total: 22.201261404s, 1015mb allocated 1060mb resident
Total: 21.804261123s, 951mb allocated 996mb resident

custom-green~2
Total: 22.062337695s, 1029mb allocated 1076mb resident
Total: 21.612443837s, 1022mb allocated 1069mb resident
Total: 21.77718634s, 1030mb allocated 1077mb resident

ParseQuery is now at 9 MB, down from 18 MB in #2161 and 30 MB on the original code. Still not sure how relevant it is. Performance seems unchanged. The CI failure is caused by formatting.

@CAD97 CAD97 mentioned this pull request Nov 5, 2019
Closed
@CAD97 CAD97 closed this Nov 19, 2019
@CAD97 CAD97 deleted the custom-green branch November 19, 2019 19:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@CAD97 @lnicola